Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django admin base_site templates #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JobDoesburg
Copy link
Contributor

Removes a bootstrap dependency and uses the Django admin base_site template for IdP test and error pages

@dcwatson
Copy link
Member

dcwatson commented Jul 6, 2022

Thanks for the PR, I like the idea! However, while it does remove the bootstrap dependency, it also means you need to have django.contrib.admin installed to find the base templates. In reality, these templates should be overridden for production sites anyway, but I think having a default that works without the admin installed is probably a good thing.

I'll leave this open to think on for a little while. Let me know if you have any more thoughts about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants